Improve ObservableAsPropertyAttribute with string#376
Merged
glennawatson merged 2 commits intomainfrom Jan 25, 2026
Merged
Conversation
Introduces the PLCInstance class to represent a PLC in the application. Updates TestViewModel to include reactive and observable properties for PLC instance, active status, and port, with initial values. Improves ObservableAsPropertyAttribute documentation and initial value handling in source generator. Updates solution file format from .sln to .slnx.
Updated the property type check to use EndsWith("##string") and EndsWith("##string?") instead of direct equality. This ensures correct initialization for string properties with type suffixes.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 43.54% 43.52% -0.03%
==========================================
Files 75 75
Lines 3991 3993 +2
Branches 484 485 +1
==========================================
Hits 1738 1738
- Misses 2095 2096 +1
- Partials 158 159 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glennawatson
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #370
What is the current behavior?
#370
What is the new behavior?
Updates solution file format from .sln to .slnx.
Improves ObservableAsPropertyAttribute documentation and initial string values handling in source generator.
Test improvements
Introduces the PLCInstance class to represent a OAPH property from a class in the application.
Updates TestViewModel to include reactive and observable properties for PLC instance (class), active status (sting), and port (int), with initial values.
What might this PR break?
None, existing code would cause non compliable code.
Please check if the PR fulfills these requirements
Other information: